Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add cargo build and build guide #111

Merged
merged 2 commits into from
Dec 7, 2023
Merged

chore: Add cargo build and build guide #111

merged 2 commits into from
Dec 7, 2023

Conversation

manuzhang
Copy link
Contributor

No description provided.

liurenjie1024
liurenjie1024 reviewed Nov 30, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
liurenjie1024
liurenjie1024 reviewed Nov 30, 2023
View reviewed changes
Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this pr!

liurenjie1024
liurenjie1024 approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Xuanwo
Xuanwo approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@manuzhang
Copy link
Contributor Author

@Fokko any more comments?

Fokko
Fokko approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @manuzhang for working on this! And @liurenjie1024 @Xuanwo @fqaiser94 for the reviews! 🙌

@Fokko Fokko merged commit ffa3a5c into apache:main Dec 7, 2023
6 checks passed
@manuzhang manuzhang deleted the add_build_guide branch June 4, 2024 11:09
shaeqahmed pushed a commit to matanolabs/iceberg-rust that referenced this pull request Dec 9, 2024
@manuzhang @shaeqahmed
chore: Add cargo build and build guide (apache#111)
b371bf1 
* chore: Add cargo build and build guide

* Make guide more concise
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fqaiser94 fqaiser94 fqaiser94 approved these changes

@Xuanwo Xuanwo Xuanwo approved these changes

@liurenjie1024 liurenjie1024 liurenjie1024 approved these changes

@Fokko Fokko Fokko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@manuzhang @Fokko @liurenjie1024 @Xuanwo @fqaiser94